Add name to event data #2
Conversation
|
|
||
| req = self.httpClient.request(location, xml, function(err, response, body) { | ||
| var result; | ||
| var obj; | ||
| self.lastResponse = body; | ||
| self.lastResponseHeaders = response && response.headers; | ||
| self.emit('response', body); | ||
| self.emit('response', body, name); |
There was a problem hiding this comment.
Shouldn't we also combine this and above into soapSuccess, so the request and response are correlated into one entry?
There was a problem hiding this comment.
Adding a new event soapSuccess? We could. Then we only need to handle 2 events. But I assume we don't want to remove any existing events for backward compatibility.
|
@y-tang - How does this fit in |
|
@shelbys I have not updated |
@shelbys @pikajude review please