refactor: glob by default for commands #492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes:
globStart
defaults to 1allowGlobbing: false
Commands have been refactored to take advantage of this new default value.
Also, this PR begins to store default values in a JS object for each
wrapOption
, which will probably make it easier to keep track of the defaults in the long run. Because this usescommon.expand()
, this will have a slight conflict with #490 (this is just because I renamedexpand
toobjectAssign
in that PR). I'll resolve the conflict after either PR is merged and update accordingly.This might be a good time to discuss if we want
wrapOutput
to be true by default, since it seems like it'll be the norm for a command to use that option.