Adding a global --negate flag #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfischer
reviewed
Nov 29, 2021
src/shx.js
Outdated
| @@ -115,6 +115,11 @@ export function shx(argv) { | |||
| code = ret ? 0 : 1; | |||
| } | |||
|
|
|||
| // Check for negation flag, and flip the code value | |||
| if (parsedArgs.negate === true) { | |||
| code = (code + 1) % 2; | |||
There was a problem hiding this comment.
This is a little confusing to read. How about this instead?
code = Number(!code);
nfischer
requested changes
Nov 29, 2021
test/specs/cli.js
Outdated
| @@ -134,6 +134,15 @@ describe('cli', () => { | |||
| output.code.should.equal(2); | |||
| }); | |||
|
|
|||
| it('uses --negate to allows for "not" conditions ', () => { | |||
| const woNegate = cli('test', '-d', 'fakeDirName'); | |||
There was a problem hiding this comment.
nit: please spell out "without" and "with" in the variable names. It just helps with readability a bit.
test/specs/cli.js
Outdated
| const wNegate = cli('--negate', 'test', '-d', 'fakeDirName'); | ||
| wNegate.stdout.should.equal(''); | ||
| wNegate.stderr.should.equal(''); | ||
| wNegate.code.should.equal(0); |
There was a problem hiding this comment.
Can you add another test case where the command normally succeeds but --negate gives it a status of 1? The true command should be a good example to use for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I recently used shx and came across the problem of negating a condition.
So, referencing this #173, I implemented a global --negate flag.