Skip to content

Replace url-regex and is-url-superb with custom implementation #120

@richardowen

Description

@richardowen

Feature Use Case

There is an open security vulnerability in url-regex (kevva/url-regex#70) and no patch available. The url-regex dependency isn't actually used by this package but even if it was removed, it would still be required further down the dependency tree by is-url-superb. It has been removed as a dependency of that package but upgrading isn't an option as that package now doesn't class protocol-relative URLs as valid. Protocol-relative URLs are valid in CSS so we want to allow them in this package. See #119 for more discussion.

Feature Proposal

  • Implement a new isUrl check in this package
    • This could use the Node.js URL class for the bulk of validation but also needs to allow protocol-relative URLs (not allowed by the URL class)
  • Remove the is-url-superb and url-regex dependencies

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions