Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
This changes the parser algorithm for Numerics to follow the CSS Syntax specification for Numeric Tokens.
This resolves various issues I am having, where numbers as plain as
32deg
or as modern as1138--hex
are considered words by this tool.The code is not lifted from any other tool that I know of, but written by me from my own RegExp implementation of the CSS Syntax, which I have yet to finish or release, and maybe never will.
If fortune allows you to work on OSS, I would greatly appreciate an updated patch or minor release. This PR does remove the internal
parseUnit
andtestUnit
static methods, but those methods were undocumented, and both thetest
andfromTokens
methods continue to work as expected.