-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to peerDependenciesMeta #11
Conversation
Please provide a link to NPM documentation or an NPM specification that details the |
@shellscape I found it here at the npm blog: https://blog.npmjs.org/post/186983646370/npm-cli-roadmap-summer-2019
Also here in the changelog: https://github.com/npm/cli/releases/tag/v6.11.0 Also the release announcement: https://npm.community/t/release-6-11-0/9572 But I can't find it in the docs. |
I just created an issue to request docs: npm/cli#1247 |
👍 Let's wait to see what they say about updating the docs. |
Ok! But isn't the blog and changelog enough to support it? I say this because seeing the issues they have, it seems that they take a long time to respond... Thanks in advance and thank for the plugin! |
I'll see what I can do to get eyes on that through back channels. NPM supports a ton of properties so things don't break, but the list of properties that are first-class official NPM properties that are the baseline for an NPM package is pretty short. It's a bit of a rabbit hole to support all possible properties in this plugin, so a baseline is needed, which is why I go from the docs or accepted spec from NPM itself. |
Got it, thanks again! |
In case this information helps you, we have just started using that property to avoid the warnings that the official NPM CLI gives when you do not install all the peer dependencies. If we do not use this property, it is the official NPM CLI that shows us the warning. |
@shellscape official documentation is coming! npm/cli#1822 |
that's great. since it's got acknowledgement from NPM, we can add support here. Please do update the README and we should be good. |
@shellscape done! |
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Fix #10