Pass entrypoints
param to generate
function
#192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
create-react-app
and would like to generate theindex.html
file on the server. In order to get code splitting to work, we need to know which code chunks are entrypoints of the React app (to be able to request these from the HTML file).In facebook/create-react-app#5513 (comment), it was suggested to add an
"entrypoints"
key tocreate-react-app
'sasset-manifest.json
file with a list of these chunks (in the order they need to be included).This PR passes an additional parameter called
entrypoints
to thegenerate
function, which provides enough information to be able to build such a manifest file.