Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass entrypoints param to generate function #192

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Pass entrypoints param to generate function #192

merged 2 commits into from
Sep 23, 2019

Conversation

samuelmeuli
Copy link
Contributor

We are using create-react-app and would like to generate the index.html file on the server. In order to get code splitting to work, we need to know which code chunks are entrypoints of the React app (to be able to request these from the HTML file).

In facebook/create-react-app#5513 (comment), it was suggested to add an "entrypoints" key to create-react-app's asset-manifest.json file with a list of these chunks (in the order they need to be included).

This PR passes an additional parameter called entrypoints to the generate function, which provides enough information to be able to build such a manifest file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants