V-slot naming inside DOM template fix #1679
Open
+2,589
−4,769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the slot names from camelCase to kebab-case due the browser behaviour when you write the template directly inside the DOM. V-slot name is and attribute and the browser normalise that to all-lowercase. Also modified the README.md to display kebab-case instead of camelCase.
|
While using this library with some colleagues, we ran into this issue and we think that the requested solution is the best fix. Would be greatly appreciated if you could accept so we can continue using the library. |
|
This PR looks good, however, this introduces a breaking change around the naming of slots. The current version we are working towards that supports Vue 3 we want to avoid adding breaking changes where we can (see #1589 for the roadmap). Because of this, I'm keen to hold off releasing this, and have it as part of version 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the slot names from camelCase to kebab-case due the browser behaviour when you write the template directly inside the DOM. V-slot name is an attribute and the browser normalises that to all-lowercase. Also modified the README.md to display kebab-case instead of camelCase.