-
-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable autocomplete in Chrome #922
Conversation
Hey! Thanks for the contribution. How does the change affect other browsers like Firefox or Safari? |
Sorry, I havent had time to test this yet. I'll setup a jsfiddle/codesandbox to test this soon 👍 |
Created a codesandbox with this fix in place. Sorry for the delay. Seems to work as expected on Safari & Firefox 👍 |
Hi @shentao :) Do you intend to merge this anytime soon? |
Thank you @miralize! |
@shentao any plans to release this hotfix with new minor version? |
Released! Thanks @shentao, cant wait for v3 :) |
hi @miralize , which version is this fix in? Thank you |
"nope" does not work on my Chrome 74.0.3729.157 Mac. If changed to off, all works ok |
Thanks @AlanRezende! Will have to revert it. |
Hmmm. I tested my code sandbox yesterday on Chrome 74. Still works as intended for me |
Also doesn't work on my chrome 74.0.3729.131 Ubuntu 16.04. @shentao Why can't we have a prop to control this value? |
They definitely changed back from nope to off for this feature in chrome recently. A revert at your earliest convenience would be much appreciated @shentao . |
This fixes #728 and is a duplicate of #769. This is important as Chrome will tend to autocomplete any input it finds.