Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable autocomplete in Chrome #922

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Disable autocomplete in Chrome #922

merged 1 commit into from
Apr 12, 2019

Conversation

seanogdev
Copy link
Contributor

This fixes #728 and is a duplicate of #769. This is important as Chrome will tend to autocomplete any input it finds.

@shentao
Copy link
Owner

shentao commented Feb 6, 2019

Hey! Thanks for the contribution. How does the change affect other browsers like Firefox or Safari?

@seanogdev
Copy link
Contributor Author

Sorry, I havent had time to test this yet. I'll setup a jsfiddle/codesandbox to test this soon 👍

@seanogdev
Copy link
Contributor Author

Created a codesandbox with this fix in place. Sorry for the delay. Seems to work as expected on Safari & Firefox 👍

https://r0y0w8r5mm.codesandbox.io

@micbra
Copy link

micbra commented Apr 11, 2019

Hi @shentao :) Do you intend to merge this anytime soon?

@shentao shentao merged commit 8c162dd into shentao:master Apr 12, 2019
@shentao
Copy link
Owner

shentao commented Apr 12, 2019

Thank you @miralize!

@dukhevych
Copy link

@shentao any plans to release this hotfix with new minor version?

@seanogdev
Copy link
Contributor Author

seanogdev commented Apr 27, 2019

Released! Thanks @shentao, cant wait for v3 :)

@Nitsorn
Copy link

Nitsorn commented May 8, 2019

hi @miralize , which version is this fix in? Thank you

@seanogdev
Copy link
Contributor Author

In https://github.com/shentao/vue-multiselect/releases/tag/2.1.6

@AlanRezende
Copy link

"nope" does not work on my Chrome 74.0.3729.157 Mac.

If changed to off, all works ok

@shentao
Copy link
Owner

shentao commented May 17, 2019

Thanks @AlanRezende! Will have to revert it.

@seanogdev
Copy link
Contributor Author

Hmmm. I tested my code sandbox yesterday on Chrome 74. Still works as intended for me

@brainyl
Copy link

brainyl commented Jun 7, 2019

Also doesn't work on my chrome 74.0.3729.131 Ubuntu 16.04. @shentao Why can't we have a prop to control this value?

@gunslingerdoug
Copy link

They definitely changed back from nope to off for this feature in chrome recently. A revert at your earliest convenience would be much appreciated @shentao .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove autocomplete in chrome browser
8 participants