Fan improvements #109
Merged
Fan improvements #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will finally be removed in 2022.04 release.
…tage. This includes: - preset_mode and percentage are mutually exclusive, setting one disables the other; - setting percentage to 0 is the same as turning the fan off; - turning on the fan with no specified parameters is legal; let it use the most recently configured settings in the device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having spent a significant amount of time in the deep end of the fan entity in the main Home Assistant repository, I figured out we have been implementing percentage and preset_mode slightly wrong.
Note that once 2022.04 is released, we can remove the whole speed kludge altogether, but for now, leave it be, it would just make it harder to use on current releases.