Fix device host discovery in config flow #52
Conversation
| @@ -214,6 +214,7 @@ async def _async_get_entry_data( | |||
| ) -> Optional[str]: | |||
| """Try connect and return config entry data.""" | |||
| device = get_device(serial, credential, device_type) | |||
| saved_host = host | |||
There was a problem hiding this comment.
Can you explain why this fixes the problem?
There was a problem hiding this comment.
During the config setup, if you leave the Host field empty it will get passed into this method as None. When this method discovers the host, it overrides the host variable because of the nonlocal host (line 224) and the config data that is returned will have a hard-coded host value. Instead of returning the discovered host, this change will return the passed in host value (None in this case).
Later on during the entry setup the code checks if the Host value is set - https://github.com/shenxn/ha-dyson/blob/main/custom_components/dyson_local/__init__.py#L107. If this value is None then the host will be discovered automatically which is what we want.
There was a problem hiding this comment.
Thanks for the explanation. Can you add some comments here since it's a little confusing.
| @@ -214,6 +214,7 @@ async def _async_get_entry_data( | |||
| ) -> Optional[str]: | |||
| """Try connect and return config entry data.""" | |||
| device = get_device(serial, credential, device_type) | |||
| saved_host = host | |||
There was a problem hiding this comment.
Thanks for the explanation. Can you add some comments here since it's a little confusing.
I setup my device with host discovery, but at some point the IP address of the device changed and HA lost connectivity. Looking through the code, the devices support discovery in
async_setup_entrybut only if thehostwas not set during the config flow.Turns out the discovered host is being returned from
_async_get_entry_dataand saved to the config entry data. This small PR fixes that issue and will cause the host to be auto discovered.