Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pasargard driver #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

golmohammadi2008
Copy link

Description

Describe your changes in detail.

Motivation and context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@hadikhanian
Copy link
Contributor

سلام. دوست عزیز به نظرم این خط زیر رو نباید حذف میکردید.
چون کل این پکیج به صورتی طراحی شده که هم از ریال هم از تومان پتشبانی کنه.
$amount = $this->invoice->getAmount() * ($this->settings->currency == 'T' ? 10 : 1); // convert to rial
همین طور این پارامتر رو از توی کانفیگ هم حذف کردید. که باید دوباره برشگردونید.
'currency' => 'R'
داخل Verify هم بررسی کنید که عدد تراکنش با همون واحدی باشه که موقع ارسال به درگاه ایجاد کردید تا اون بخش مشکلی رخ نده.

باقی تست های که failed شده رو هم بررسی کنید اگر کمکی از دست بنده بر میاد بفرمایید.
چون منم میخواستم روی این نسخه جدید پارسارگاد کار کنم که دیدم شما زحمت بخش زیادیش رو انجام دادید.

@golmohammadi2008
Copy link
Author

'currency' => 'R'
سلام دوست عزیز چون ما توی بک پروژه این رو نوشتیم اینجا برش داشتم.
اضافه میگردد.

@hadikhanian
Copy link
Contributor

مشکل الان کجاست؟
این مورد رو زودتر رفع کنیم آپدیتش رو قرار بدیم روی نسخه اصلی
کمکی از دست من بر میاد بفرمایید.

@khanzadimahdi
Copy link
Member

مشکل الان کجاست؟ این مورد رو زودتر رفع کنیم آپدیتش رو قرار بدیم روی نسخه اصلی کمکی از دست من بر میاد بفرمایید.

شما هم میتونید PR جداگانه ای ارائه بدید! این PR احتمالا بلاک شده! اگه میخواید سریعتر انجام بشه میتونید PR بزارید.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants