Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for deprecated method. #17

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Fix warning for deprecated method. #17

merged 1 commit into from
Dec 7, 2020

Conversation

SlaunchaMan
Copy link
Contributor

@SlaunchaMan SlaunchaMan commented Dec 7, 2020 •
edited
Loading

This PR fixes the warning for using encodedOffset, using the String index directly instead. Fixes #16.

f-meloni
f-meloni approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@f-meloni f-meloni merged commit 6e7415d into shibapm:master Dec 7, 2020
@SlaunchaMan SlaunchaMan deleted the fix-encoded-offset-warning branch December 7, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning for encodedOffset
2 participants
@SlaunchaMan @f-meloni