unable to complete browser login flow

[shiftkey]

Description

The latest beta snap can launch the browser login flow, but it doesn't seem to have the associated protocol handler registered to launch when the callback fires.

Version

• GitHub Desktop: 1.6.5-linux6
• Operating system: Ubuntu 18.04

Steps to Reproduce

1. snap install github-desktop --beta --classic
2. launch the app
3. "Sign in using your browser"
4. Browser launches
5. Complete flow, browser indicates it is returning you to the app

Expected Behavior

Welcome wizard proceeds to next step

Actual Behavior

Nothing

Additional Information

I gather something needs to be declared in the snap.yaml file like this, based on the VSCode config:

  url-handler:
    command: electron-launch $SNAP/usr/share/@@NAME@@/bin/@@NAME@@ --open-url
    desktop: usr/share/applications/@@NAME@@-url-handler.desktop
    environment:
      DISABLE_WAYLAND: 1
      GSETTINGS_SCHEMA_DIR: $SNAP/usr/share/glib-2.0/schemas

[shiftkey]

Note: On Chrome OS, the Linux world and the Chrome OS world are somewhat separate - I don't know whether it's possible for Linux apps to register protocol handlers that work in the main Chrome browser (though note that I know almost nothing about this setup, I just enabled it on a Pixelbook and decided to see what worked and what doesn't).

Yeah, I think this might be a limitation beyond our control. I've moved this out to #138 to track as a separate issue (this one is related to the Snap package).

[MikailBag]

I experience same problem in Ubuntu: "Sign in" progress bar keeps running, but nothing happens.

[jfclere]

On Fedora 31 and FireFox you are able to do sign in in github but firefox doesn't return to application and instead displays an error page.
x-github-desktop-dev-auth://oauth?code=4fb975533c2XXXXX&state=7af24cfa-9256-4886-b3bf-245XXXXX
"The address wasn't understood"

[pferioli]

I have the same problem using GitHub Desktop 2.0.4-linux1 / Ubuntu 18.04 LTS

After validating the user, when callback, i get a 404 error instead of finishing the process in the application. I'm not able to sign in with the enterprise account.

Tested with firefox and Chrome.

2020-04-01T21:06:20.148Z - info: [ui] proxy url not resolved, protocol not supported
2020-04-01T21:06:23.141Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 2.938s)
2020-04-01T21:32:47.123Z - info: [ui] [SignInStore] initializing OAuth flow
2020-04-01T21:32:47.138Z - info: [main] opening in browser: https://github.xxxxxx.com/login/oauth/authorize?client_id=3a723b10ac5575cc5bb9&scope=repo%20user&state=4a63ab04-f31d-494c-bbdc-2e2200e1a7ac

[latot]

Hi, I use gentoo and downloaded the latest AppImage, happend the same over firefox, The address wasn't understood

[shiftkey]

Closing this out as I don't have plans to revive Snap support