Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-in with browser launches seperate profile #157

Closed
ghost opened this issue Jun 19, 2019 · 3 comments
Closed

Sign-in with browser launches seperate profile #157

ghost opened this issue Jun 19, 2019 · 3 comments
Labels
installers/snap Issues related to the Snap installer unclear

Comments

@ghost
Copy link

ghost commented Jun 19, 2019

Description

Once beta snap is installed any attempts to login using the browser option launch the default browser as expected. While I did see the login loop as in #134, the snap opened and entirely new profile under my browser( Vivaldi latest stable 2.5). This new profile is odd because its like i had just fresh installed vivaldi.

Version

  • GitHub Desktop: 2.0.4-linux1
    Vivaldi: 2.5.1525.48

  • Operating system:
    Pop!_OS 19.04

Steps to Reproduce

  1. Install github desktop and vivaldi
  2. Setup test profile on vivaldi
  3. Launch github desktop and clikc the sign in with browser

Expected Behavior

Launched browser was expected to be a new tab of my current opened profile with access to my password manager and accounts

Actual Behavior

The browser launched seems to create a temporary new profile that cannot see or access any profiles, extensions, or any other data avaliable to the normal profiles.

Additional Information

Normal Browser
Screenshot from 2019-06-18 23-56-11
Browser made by Github Desktop
Screenshot from 2019-06-18 23-55-32
Found where the snap is pulling the profile from
Screenshot from 2019-06-19 00-10-32
seems to make its own configuration folder for vivaldi from within its own snap folder?

Logs

heres log idk if important
2019-06-19.desktop.production.log

@ghost ghost changed the title Sign-in with browser launches odd profile Sign-in with browser launches seperate profile Jun 19, 2019
@shiftkey
Copy link
Owner

The browser launched seems to create a temporary new profile that cannot see or access any profiles, extensions, or any other data avaliable to the normal profiles.

I'm not quite sure what sort of sandboxing the runtime is doing here, but I'm not sure this is an easy fix for Desktop to do 🤔

@shiftkey shiftkey added installers/snap Issues related to the Snap installer unclear labels Jun 19, 2019
@ghost
Copy link
Author

ghost commented Jun 19, 2019

The browser launched seems to create a temporary new profile that cannot see or access any profiles, extensions, or any other data avaliable to the normal profiles.

I'm not quite sure what sort of sandboxing the runtime is doing here, but I'm not sure this is an easy fix for Desktop to do

Yep. I just wanted to put it the issue somewhere. It doesn't really bother me since I never use the view on github button

@shiftkey
Copy link
Owner

shiftkey commented Apr 4, 2020

I'm going to close this out for now to keep the issue tracker under control, as I am unable to package Snaps locally to revisit issues with Snaps like this one. Please follow along with #203 in the meantime.

@shiftkey shiftkey closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installers/snap Issues related to the Snap installer unclear
Projects
None yet
Development

No branches or pull requests

1 participant