Update package scripts for multiple architectures #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theofficialgman thanks for the contribution! I've opened #774 which should achieve what you need in a more succinct manner, and I'll get this merged so it'll hopefully make your work easier... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does some work on #251
Description
changes the hardcoding of a single architecture to an architecture set at build time dependent on the running process architecture.
Notes
as I have said before, I am not a programmer, so if this syntax is horrible I am sorry. It does work however and means that arm64 linux no longer needs any local patching to build (besides building and shimming in dugite-native). This also makes it easier to build armhf linux (though that is still more difficult since the windows node dependencies and scripting has to be fully removed due to winstaller still being installed on linux)