feat: random of aspect ratio #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter allows users to specify how much variance in the aspect ratio to allow when searching for an image. In the event an image still isn't found that matches the aspect ratio, the next closest is still returned.
|
Looks Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality that allows users to request a random image of a specific aspect ratio. Currently, the logic works as follows:
I messed with a few ideas like grouping images with similar aspect ratios to improve selection, but this ended up not working super well as it merged some common aspect ratios. Someone more familiar with fuzzy grouping might have a better solution than I did to resolve that issue. In the meantime, an
aspect-ratio-varianceparameter is available that allows users to specify how much variance to use when filtering images to be randomly returned.I did not implement tests as v3 does not have them, but can if requested.