fix: svelte types generation during build #14
Conversation
src/svelte/ShikiMagicMove.svelte
Outdated
| @@ -1,8 +1,8 @@ | |||
| <script lang="ts"> | |||
| import { codeToKeyedTokens, createMagicMoveMachine } from '../core' | |||
| import { codeToKeyedTokens, createMagicMoveMachine } from '../core.mjs' | |||
There was a problem hiding this comment.
This will break dev (the playground)
There was a problem hiding this comment.
I'm not sure how to fix it
There was a problem hiding this comment.
shipping core.ts, renderer.ts and types.ts will fix it. Because svelte files are compiled with the svelte version of the user of the library through vite. Do you think it will be feasible and possible through unbuild?
There was a problem hiding this comment.
for the moment i've added some other fs.copyFile, i don't know if there's a better way but this should make everything works both in the playground and in imported svelte projects.
Do you have a quick way to test this in react and vue too?
There was a problem hiding this comment.
I don't think shipping source files is a good idea. I feel it would be better if we could somehow compile the svelte file to pure JS, or rewrite the path on build
There was a problem hiding this comment.
if we could replace the extension at build time it would be great
There was a problem hiding this comment.
Coming in from left field to suggest either:
- all build files are outputted as
.js(you have type module set so shouldn't break anything). That way in TS files you can import with.jsextensions which will work during both dev and builds (being explicit is usually better anyway) - dev uses a built version of the library rather than the TS source
There was a problem hiding this comment.
I don't think shipping source files is a good idea. I feel it would be better if we could somehow compile the svelte file to pure JS, or rewrite the path on build
Compile svelte files to js is not the right approach because that would mean the compilation is stuck at the build moment. This basically means that if the user uses a different svelte version it might be uncompatible.
We can rewrite path on build although i see this solution as a bit more brittle than actually shipping the typescript files to allow them to be compiled at build time by the user.
The suggestion from @ghostdevv is also a good compromise imho.
|
Released as v0.4.1 - let me know if it works or not |
|
@antfu everything seems to work great, thank you! 🙏 |
Very good solution. Thanks. |
This should fix the type problems for the svelte renderer
cc. @mattcroat