feat: add solid integration #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: solid playground now runs
fix: solid renderer disposes properly
fix: Solid bundling now works
…to feat/add-solid
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for not creating an issue first.
This PR adds a Solid version of the component.
There was some work that needed to be put into the build process to support Solid's and React's JSX living side by side in the playground. Thanks to @crutchcorn for helping me with that.
I am happy to update the README with the appropriate snippet if the rest of this PR looks good.
Note
There is a quirk to rendering. The changes to stagger, lineNumbers, and other renderer options do not take effect until "Toggle Examples" is clicked. This is thought to be related to the two reactive systems, Vue and Solid, not working well together.