Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): move "animating" text below codeblock #5

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

McPizza0
Copy link
Contributor

@McPizza0 McPizza0 commented Mar 6, 2024

fix #4

@antfu
Copy link
Member

antfu commented Mar 6, 2024

I guess maybe instead of removing the element, we could toggle the opacity to zero, so it doesn't cause the layout shift. The reason I don't want to put it below is that the container might resize and cause the indicator moves

@McPizza0
Copy link
Contributor Author

McPizza0 commented Mar 6, 2024

toggle the opacity to zero

thats fair and a good approach
it would leave an misalignment between the input and shiki though
image

another alternative is to place it inline with the button
image

@antfu
Copy link
Member

antfu commented Mar 6, 2024

I am up for that. We will find a better way to indicate that later.

@McPizza0
Copy link
Contributor Author

McPizza0 commented Mar 6, 2024

updated

@antfu antfu merged commit 129fae8 into shikijs:main Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground: "Animating" text shift code block, breaking immersion
2 participants