-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate deployment #57
Comments
Sure 👍 |
is there a nightly shiki build on npm? |
@orta @octref Any thoughts if I take a stab on the GitHub actions to make this happen? Current behavior:
Proposed behavior:
|
@muenzpraeger Looks great 👍 Doing it in two parts would be best, eg first the "don't fail hard" part, then the commit/version/publish flow. I still think fetching grammar/theme and publishing should be separate actions. |
@octref Agree in the separation. The coupling I was thinking about to trigger version/publication via a workflow event after grammar/theme updates. Although I'm wondering about the right balance for auto-publication. I mean, even with only a weekly one it could be like 52 patch versions/year on the main package. Or maybe the way would be to separate grammars/themes into a dedicated package. |
I don't know about another package though – I still believe people should download one package and be able to start using it. However, one structure this could take is:
|
I'd say I'll get as a first step a PR up for issue creation in case of grammar/theme update issues. And we'll discuss with v1 on nightlies. Now that there are breaking changes on the table it's way easier to draw ideas. ;-) My thinking re: packages was conceptually like this. {
"name": "@shiki/core",
"version": "1.0.0",
"dependencies": {
"@shiki/themes": "^1.0.0",
"@shiki/grammars": "^1.0.0"
}
} That way theme/grammar could have nightly packages, and "core" would not need them. And taking it further... implementing the package configs via the project config. Which could then also be a standard way for people to add their own customizations. {
"name": "@muenzpraeger/my-custom-shiki-theme",
"version": "0.2.1",
"shiki": {
"themes": {
"my-custom-theme": "./my-custom-theme.json"
}
}
} Just a thought. ;-) |
Yeah, similar to what I'm thinking. |
I built a nightly deploy tool which we use in the svelte language-tools monorepo which would work perfect for this repo. On top of that it was on my todo to create orta/monorepo-deploy-nightly#6 which is useful for both
The text was updated successfully, but these errors were encountered: