Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GH issue creation for failing grammars #430

Closed

Conversation

muenzpraeger
Copy link
Collaborator

  • This PR fixes Automate deployment #57

  • The scripts pullGrammarsFromGitHub.ts was extended to output errors for failed grammar downloads if the arg --output-errors is set.

  • The output is stored in tmp/errros.grammar.json.

  • The script createGitHubIssues.sh queries the output of the error file and creates new issues.

// example error output
{
  "errors": [
    {
      "language": "abap",
      "step": "Initial fetch",
      "message": "404 Not Found",
      "success": false,
      "type": "grammar",
      "url": "https://github.com/pvl/abap.tmbundle/blob/master/Syntaxes/ABAP.tmLanguage"
    }
  ]
}

@antfu
Copy link
Member

antfu commented Jan 26, 2024

Hey, thanks for your contribution! With the recent rewrite of v1.0, we have moved the grammars out of this repository. Which should fix the original issue.

@antfu antfu closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants