Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mips assembly grammar #508

Closed
wants to merge 2 commits into from
Closed

Conversation

parksb
Copy link

@parksb parksb commented Aug 7, 2023

  • Add a test if possible
  • Format all commit messages with Conventional Commits
  • I have read docs for adding a language.
  • I have searched around and this is the most up-to-date, actively maintained version of the language grammar.
  • I have added a sample file that includes a variety of language syntaxes and succinctly captures the idiosyncrasy of a language. See docs for requirement.

@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for shiki-matsu failed.

Name Link
🔨 Latest commit 8da4e6d
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/64d07b298db0b80008512011

Copy link
Collaborator

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name it with the id mips and use mipsasm as the alias?

@parksb
Copy link
Author

parksb commented Aug 7, 2023

Can we name it with the id mips and use mipsasm as the alias?

I edited it.

@parksb parksb requested a review from octref September 10, 2023 13:30
@antfu
Copy link
Member

antfu commented Jan 26, 2024

Hey, thanks for your contribution! With the recent rewrite of v1.0, we have moved the grammars out of this repository. We generally suggest you loading the grammar locally to move forward. If you believe this is the language that is widely used, you can send an issue or PR to this repo: https://github.com/shikijs/textmate-grammars-themes

Thank you!

@antfu antfu closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants