Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add additional sample code #511

Merged
merged 2 commits into from
Aug 16, 2023
Merged

feat: add additional sample code #511

merged 2 commits into from
Aug 16, 2023

Conversation

KevinBatdorf
Copy link
Contributor

This PR

  1. adds the missing sample codes (I believe I covered them all here)
  2. renames Marko.sample to marko.sample to reflect the manifest file.
  3. Updates a few that didn't seem like good representations of the language (too short, not enough tokens, etc)

I tried to find reputable sources for all the code.

@netlify
Copy link

netlify bot commented Aug 16, 2023 •
edited
Loading

❌ Deploy Preview for shiki-matsu failed.

Name Link
🔨 Latest commit f632880
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/64dc5143fde32700083e9c75

@orta
Copy link
Contributor

orta commented Aug 16, 2023

Wow, that must have been quite some work, we should get this in regardless of those missing snapshots

@orta orta merged commit 0627640 into shikijs:main Aug 16, 2023
@KevinBatdorf KevinBatdorf deleted the add-missing-sample-code branch August 16, 2023 13:15
@KevinBatdorf
Copy link
Contributor Author

Was quite tedious but needed them for a side project anyway 😅

@Elenore23 Elenore23 mentioned this pull request Jul 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBatdorf @orta