Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): skip bundling for assets #795

Merged
merged 2 commits into from
Sep 29, 2024
Merged

feat(perf): skip bundling for assets #795

merged 2 commits into from
Sep 29, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 29, 2024

Directly copy the assets to dist, instead of rebundling them.

Not sure if it would improve the situation of #784 as a side effect

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 62e01c1
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/66f8ab7f7bc8780008add087
😎 Deploy Preview https://deploy-preview-795--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 62e01c1
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/66f8ab7f817d95000850d390
😎 Deploy Preview https://deploy-preview-795--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 99.82669% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.91%. Comparing base (c8accc9) to head (62e01c1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/shiki/src/langs.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
+ Coverage   92.88%   94.91%   +2.02%     
==========================================
  Files          76       78       +2     
  Lines        4597     6488    +1891     
  Branches     1020     1296     +276     
==========================================
+ Hits         4270     6158    +1888     
- Misses        318      321       +3     
  Partials        9        9              
Flag Coverage Δ
94.91% <99.82%> (+2.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu merged commit 0c5a51a into main Sep 29, 2024
13 checks passed
@antfu antfu deleted the feat/skip-assets-bundle branch September 29, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant