Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search from other known buckets #26

Closed

Conversation

beer-psi
Copy link

@beer-psi beer-psi commented May 14, 2022

This PR uses the GitHub API to search packages from other known buckets:

scoop-search on  master [!?] via 🐹 v1.18.1 
❯ .\scoop-search.exe cascadia
Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nerd-fonts' bucket (install using 'scoop install nerd-fonts/<app>'):
    Cascadia-Code
    CascadiaCode-NF-Mono
    CascadiaCode-NF

This has been a feature in scoop since 2016 (ScoopInstaller/Scoop#658):

scoop-search on  search-other-known-buckets [!?] via 🐹 v1.18.1 
❯ scoop.ps1 search cascadia
Results from other known buckets...
(add them using 'scoop bucket add <name>')

'nerd-fonts' bucket (install using 'scoop install nerd-fonts/<app>'):
    Cascadia-Code
    CascadiaCode-NF-Mono
    CascadiaCode-NF

Deviations from scoop

Can be reversed if you want to.

  • Online search ends early if the ratelimit is reached midway. I know this isn't the same behavior as scoop search, but please consider accepting it anyway, online search is useless when API limit hits anyway.
  • Uses gh_token in scoop's config if available, for higher rate limits Removed as it fails the goal of behaving the same as scoop search.

online searching prematurely ends when the API limit hits
@beer-psi beer-psi force-pushed the search-other-known-buckets branch from 94392f6 to 04b4516 Compare May 14, 2022 09:22
@shilangyu
Copy link
Owner

Unfortunately closing due to the rewrite in Zig.

I cannot believe I have never addressed this PR. I incorrectly assumed you are the person from #6, thinking that I have addressed your work. I am incredibly sorry for that.

@shilangyu shilangyu closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants