Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version to 16 #208

Merged
merged 2 commits into from
Oct 30, 2022
Merged

Conversation

duddu
Copy link
Contributor

@duddu duddu commented Oct 15, 2022

This PR updates the nodejs matrix version to 16.
As recommended by GitHub with the following warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: shimataro/ssh-key-action

Solves #207

@davereid-pfg
Copy link

https://github.com/shimataro/ssh-key-action/blob/develop/action.yml#L29 needs to be updated as well, this is not the only change needed.

@duddu
Copy link
Contributor Author

duddu commented Oct 23, 2022

thanks @davereid-pfg, updated.

@shimataro when you got time to have a glance, ping if there's anything missing/in need for update, ta!

@shimataro shimataro changed the base branch from develop to feature/nodejs-16 October 30, 2022 13:13
@shimataro
Copy link
Owner

Very sorry for late response, and thank you for your request!

Since CI fails to read secret environment variables, I merge it into my branch.
After checking, it will be merged into develop!

@shimataro shimataro merged commit 7cdf8a7 into shimataro:feature/nodejs-16 Oct 30, 2022
shimataro added a commit that referenced this pull request Oct 30, 2022
* Update nodejs version to 16 (#208)

* Update nodejs version to 16

* Update runtime used to node16

* update CHANGELOG

Co-authored-by: Davide Doronzo <duddu@users.noreply.github.com>
This was referenced Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants