Add test case for hash calculations #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While replacing the implementation of sha256, I noticed that there is no test case actually calling the hash calculations. Added two such test cases. Please note that I didn't verify that the result is correct, but just took the value the existing implementation returned. So those tests will only catch future regressions.
suhancz
added a commit
to suhancz/fido2luks
that referenced
this pull request
Nov 17, 2020
# This is the 1st commit message: Added an helper script to be used with pam_mount # This is the commit message shimunn#2: successful RPM build # This is the commit message shimunn#3: correct license # This is the commit message shimunn#4: add Makefile # This is the commit message shimunn#5: install cargo-rpm # This is the commit message shimunn#6: fix outdir # This is the commit message shimunn#7: include all the rest beside of teh binary to RPM # This is the commit message shimunn#8: test commit to figure out the failure reason
suhancz
added a commit
to suhancz/fido2luks
that referenced
this pull request
Nov 17, 2020
# This is the 1st commit message: Added an helper script to be used with pam_mount # This is the commit message shimunn#2: successful RPM build # This is the commit message shimunn#3: correct license # This is the commit message shimunn#4: add Makefile # This is the commit message shimunn#5: install cargo-rpm # This is the commit message shimunn#6: fix outdir # This is the commit message shimunn#7: include all the rest beside of teh binary to RPM # This is the commit message shimunn#8: test commit to figure out the failure reason # This is the commit message shimunn#9: don't force Rust library versions # This is the commit message shimunn#10: update build dependencies # This is the commit message shimunn#11: force-install cargo # This is the commit message shimunn#12: clean up debug info # This is the commit message shimunn#13: add cryptsetup-libs to build spec
suhancz
added a commit
to suhancz/fido2luks
that referenced
this pull request
Nov 17, 2020
# This is the 1st commit message: Added an helper script to be used with pam_mount # This is the commit message shimunn#2: successful RPM build # This is the commit message shimunn#3: correct license # This is the commit message shimunn#4: add Makefile # This is the commit message shimunn#5: install cargo-rpm # This is the commit message shimunn#6: fix outdir # This is the commit message shimunn#7: include all the rest beside of teh binary to RPM # This is the commit message shimunn#8: test commit to figure out the failure reason # This is the commit message shimunn#9: don't force Rust library versions # This is the commit message shimunn#10: update build dependencies # This is the commit message shimunn#11: force-install cargo # This is the commit message shimunn#12: clean up debug info # This is the commit message shimunn#13: add cryptsetup-libs to build spec # This is the commit message shimunn#14: force libcryptsetup-rs-sys version due to build error on COPR machines # This is the commit message shimunn#15: force cargo-rpm versin due to COPR build errors # This is the commit message shimunn#16: force lincryptsetup-rs version due to COPR build errors
suhancz
added a commit
to suhancz/fido2luks
that referenced
this pull request
Nov 17, 2020
# This is the 1st commit message: Added an helper script to be used with pam_mount # This is the commit message shimunn#2: successful RPM build # This is the commit message shimunn#3: correct license # This is the commit message shimunn#4: add Makefile # This is the commit message shimunn#5: install cargo-rpm # This is the commit message shimunn#6: fix outdir # This is the commit message shimunn#7: include all the rest beside of teh binary to RPM # This is the commit message shimunn#8: test commit to figure out the failure reason # This is the commit message shimunn#9: don't force Rust library versions # This is the commit message shimunn#10: update build dependencies # This is the commit message shimunn#11: force-install cargo # This is the commit message shimunn#12: clean up debug info # This is the commit message shimunn#13: add cryptsetup-libs to build spec # This is the commit message shimunn#14: force libcryptsetup-rs-sys version due to build error on COPR machines # This is the commit message shimunn#15: force cargo-rpm versin due to COPR build errors # This is the commit message shimunn#16: force lincryptsetup-rs version due to COPR build errors # This is the commit message shimunn#17: fix conf-files location # This is the commit message shimunn#18: debug output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While replacing the implementation of sha256, I noticed that there
is no test case actually calling the hash calculations.
Added two such test cases. Please note that I didn't verify that the
result is correct, but just took the value the existing implementation
returned. So those tests will only catch future regressions.