[WIP] Allow passing locale to queries #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pleasant surprise is that except for Column, other backends were quite easy to adapt to this feature. |
shioyama
force-pushed
the
query_locales
branch
2 times, most recently
from
66e1bd1
to
cc1e621
Compare
4 tasks
|
Although specs are passing, this is not quite working yet. It breaks if you query on more than one translated attribute with different backends in a single Will work on a fix, but for basic cases this should work. |
|
Closing this since #216 will require many changes. I'll make a new PR later once query stuff settles down a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51.
This PR works for all backends except column currently. Ironically, column is the simplest backend but supporting an array-valued
localeoption to queries (Post.i18n.where(title: "foo", locale: [:en, :fr])) is more complicated than I thought.I'm going to try getting basic specs green first, then think about how this can be cleaned up. I have a rough plan to lean much more heavily on Arel and hopefully make the query interface more flexible.