-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up and refactor active record container backend #543
clean up and refactor active record container backend #543
Conversation
0f9eab5
to
0afd7f8
Compare
Thanks for this! ❤️ Will review this week. |
ace21a7
to
e7e0b4d
Compare
I rebased everything and updated as requested:
One thing to keep in mind is that empty hashes might already exist in saved models if the container backend was used before this PR and it will not "self heal" (like it did with Edit: I did it as extra commits so you can follow it. I can squash all commits if everything is good at the end. |
e7e0b4d
to
b47131f
Compare
b47131f
to
b0613ae
Compare
Hey @shioyama, hope you're good! Any chance to review this PR again? I'd like to get this merged and off my list :-) If there are some changes needed I'll update the PR, just say so. (Edit: Just rebased it on master) |
fixes dirty tracking and creating empty translation hashes on read fixes shioyama#540
b0613ae
to
1991ddf
Compare
@doits Thanks so much, this is a really great PR! ❤️
I think that's ok, if it hasn't been a problem so far then presumably it won't suddenly start being one (for those using the container backend). |
fixes dirty tracking and creating empty translation hashes on read
fixes #540