Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid referencing ActiveRecord::Base #550

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Avoid referencing ActiveRecord::Base #550

merged 1 commit into from
Dec 4, 2021

Conversation

shioyama
Copy link
Owner

@shioyama shioyama commented Dec 3, 2021 •
edited
Loading

@shioyama
Copy link
Owner Author

shioyama commented Dec 3, 2021

@leehericks Can you try this branch? It passes all tests, it's just a simple refactor. Happy to ship it, although I'd love to actually understand what is breaking...

@shioyama shioyama mentioned this pull request Dec 3, 2021
Open
@leehericks
Copy link

@shioyama Yes this does solve the problem.

@shioyama shioyama merged commit f8e6917 into 1-2 Dec 4, 2021
@shioyama
Copy link
Owner Author

shioyama commented Dec 4, 2021

Released in 1.2.5

@shioyama shioyama deleted the delegate_ar_base_1_2 branch June 18, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shioyama @leehericks