Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rails7 default scope issue with select #582

Closed
wants to merge 2 commits into from
Closed

Fix rails7 default scope issue with select #582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8499115
Revert "Check that class responds to mobility_attribute?"
borisrorsvort Jun 22, 2022
c176171
fix: add back return values
borisrorsvort Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/mobility/plugins/active_record/query.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,8 @@ def order(opts, *rest)
define_method method_name do |*attrs, &block|
return super(*attrs, &block) if (method_name == 'select' && block.present?)

if ::ActiveRecord::VERSION::STRING < '7.0'
return super(*attrs, &block) unless @klass.respond_to?(:mobility_attribute?)
end
return super(*attrs, &block) unless @klass.respond_to?(:mobility_attribute?)

return super(*attrs, &block) unless attrs.any?(&@klass.method(:mobility_attribute?))

keys = attrs.dup
Expand Down