Support absolute paths in composer autoload sections #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fixAbsolutePath
branch
from
ea4fd26 to
54a3313
Compare
janedbal
reviewed
Aug 6, 2024
janedbal
changed the title
janedbal
force-pushed
the
fixAbsolutePath
branch
from
8b2569b to
d9a3e80
Compare
janedbal
approved these changes
Aug 6, 2024
|
Thanks ! If you have time for a patch release, this would allow me to unable again this lib on my ci :) |
|
Released as 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @janedbal,
I recently tried your lib and it's really great.
I just encounter an issue, when I use an absolute path in my
autoload.classmapkey of the composer.json, this lib consider it's a relative path when composer does resolve the absolute path. I made some checks and/srcis not found by composer (but does by your lib), so it means that composer don't have a relative-path fallback when the absolute is not found. It just respect my path./my-absolute-pathis found by composer (but not your lib)I made a fix to respect absolute path given and updated the tests.