Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First address entered during checkout is not saved to address book #13

Closed
gorillagroup opened this issue Nov 2, 2016 · 3 comments
Closed

Comments

@gorillagroup
Copy link

When the module ShipperHQ_Shipper is disabled this issue is no longer happening.
\ShipperHQ\Shipper\Plugin\Checkout\ShippingInformationPlugin is doing some things in aroundSaveAddressInformation and it seems to be causing this. I think this event "around" might not be the right one since \Magento\Checkout\Model\ShippingInformationManagement::saveAddressInformation is being called after.

Steps to reproduce:

  1. Register a new user.
  2. Complete checkout using physical product.
  3. Start checkout with another physical product in cart.
    Expected result:
    Address used on step two is saved as default shipping address and can be used on step three.
    Actual result:
    User has to enter new address from scratch.
@wsagen
Copy link
Contributor

wsagen commented Nov 2, 2016

Can you confirm the Magento version you are using? We are not seeing this issue after repeated attempts to reproduce

@gorillagroup
Copy link
Author

This project is on 2.1.2.

@wsagen
Copy link
Contributor

wsagen commented Nov 3, 2016

Reviewed with GorillaGroup and found it was unrelated to ShipperHQ. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants