Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module breaks DI compilation #25

Closed
sshymko opened this issue Jul 6, 2017 · 3 comments
Closed

Module breaks DI compilation #25

sshymko opened this issue Jul 6, 2017 · 3 comments

Comments

@sshymko
Copy link
Contributor

sshymko commented Jul 6, 2017

Environment:

  • Magento CE 2.1.x
  • ShipperHQ module v20.5.4

Steps to reproduce:

  1. Install vanilla Magento 2 via Composer
  2. Install the ShipperHQ module via Composer
  3. Run code generation and DI compilation:
php bin/magento setup:di:compile

Actual result:

  • DI compilation fails with the following error:
  [ReflectionException]                                                                                     
  Class ShipperHQ\Common\Model\Quote\Service does not exist  
  • Constructor of the class \ShipperHQ\Shipper\Observer\SaveShippingAdmin declares dependency on non-existing class \ShipperHQ\Common\Model\Quote\Service
@sshymko sshymko changed the title Module v20.5.4 breaks DI compilation Module breaks DI compilation Jul 6, 2017
@wsagen
Copy link
Contributor

wsagen commented Jul 6, 2017

Can you please verify the version of shipperhq/module-common you have. The current version can be seen in vendor/shipperhq/module-common/CHANGELOG.MD file.

The most recent version of 20.1.5 which includes the class ShipperHQ\Common\Model\Quote\Service at vendor/shipperhq/module-common/src/Model/Quote/Service.php

Can you verify the above version number and that the file is present. Please update the installation and retest if you version is lower that the above.

@wsagen wsagen closed this as completed Jul 6, 2017
@wsagen wsagen reopened this Jul 6, 2017
@sshymko
Copy link
Contributor Author

sshymko commented Jul 6, 2017

@wsagen
The changelog vendor/shipperhq/module-common/CHANGELOG.MD shows 20.1.2 (2016-12-14).
Looks like the module shipperhq/module-shipper has been upgraded w/o its dependencies.
Trying to upgrade the dependencies like so:

composer update shipperhq/module-shipper --with-dependencies --no-dev

@sshymko
Copy link
Contributor Author

sshymko commented Jul 6, 2017

Fullly upgrading the module with all dependencies resolved the issue. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants