Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deadlocks on concurrent package items replacement #35

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fix deadlocks on concurrent package items replacement #35

merged 1 commit into from
Oct 13, 2017

Conversation

sshymko
Copy link
Contributor

@sshymko sshymko commented Oct 12, 2017

@sshymko
Fix deadlocks on concurrent package items replacement
732f0e9 
- Resolve shipperhq#28 Deadlock for 2 simple insert queries on shipperhq_quote_package_items table
@sshymko
Copy link
Contributor Author

sshymko commented Oct 12, 2017

Note that there's a copy-paste in \ShipperHQ\Shipper\Model\ResourceModel\Quote\Packages and \ShipperHQ\Shipper\Model\ResourceModel\Order\Packages. The duplicated code already diverged. The deadlock fix needs to be applied to the order items same way as for the quote. Implementation should be reused.

@wsagen wsagen merged commit cd6c370 into shipperhq:master Oct 13, 2017
@chattertech chattertech mentioned this pull request Aug 14, 2018
Closed
@n2diving-dgx n2diving-dgx mentioned this pull request May 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshymko @wsagen