Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing shipping detail argument. #37

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

cykirsch
Copy link

Caused an error when loading the order detail page for an order created in Magento 1.

Caused an error when loading the order detail page for an order created in Magento 1.
@TravisBernard
Copy link

Thanks for submitting this @cykirsch we'll review

@TravisBernard TravisBernard self-requested a review January 22, 2018 16:18
@TravisBernard TravisBernard self-assigned this Jan 22, 2018
Copy link
Contributor

@wsajosh wsajosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was excluded accidentally. It's required in order to get the address valid status as well as all info held in the carrier group shipping details such as origin information, delivery dates and carrier details

@wsajosh wsajosh merged commit 54a60a4 into shipperhq:master Jan 26, 2018
TravisBernard pushed a commit that referenced this pull request Dec 3, 2018
SHQ16-2141 UPS LTL use carrier code as type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants