Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: API responses contain HTTP links to download URLs from the main download server #562

Closed
ericswpark opened this issue Aug 17, 2024 · 1 comment
Closed

bug: API responses contain HTTP links to download URLs from the main download server #562

ericswpark opened this issue Aug 17, 2024 · 1 comment
Assignees
@ericswpark
Labels
bug Something isn't working

Comments

@ericswpark
Copy link
Collaborator

What subsystem are you reporting a problem with? (Hint: you can select multiple!)

shipper (API)

What happened?

When fetching from the updater API, the download URL from the main server is in HTTP, even though the site is served over HTTPS

What can we do to reproduce the problem?

  1. Make any request to an updater API endpoint

Relevant log output

No response

shipper version

2.40.0

shippy version

N/A

Anything else?

No response
@ericswpark ericswpark added the bug Something isn't working label Aug 17, 2024
@ericswpark ericswpark self-assigned this Aug 17, 2024
ericswpark added a commit that referenced this issue Aug 17, 2024
@ericswpark
release: 2.41.0
26f40c7 
This release contains a database migration.


- Added a feature model for Build objects (database only for now) (#354)
- Added checks to disallow Postgres-specific fields
- Added management commands for initializing a demo environment (#218)
- Added a device note edit screen for maintainers (#527)

- Fixed some models not being picked up in the audit log
- Fixed a React key issue in a list on the frontend
- The SQLite3 backend correctly utilizes the given database name in the config
- Fixed issues loading the `crispy` form filters
- Clarified account management texts
- Fixed maintainer URLs as they were incorrectly being cached
- Fixed a bug with HTTP/HTTPS URL generation with the protocol forwarded by nginx (#562)
- General code cleanup
- Updated dependencies (server)
	- @babel/core (7.24.8 -> 7.25.2)
	- prettier (3.3.2 -> 3.3.3)
	- sentry-sdk (2.9.0 -> 2.13.0)
	- django-crispy-forms (2.2 -> 2.3)
	- typescript (5.5.3 -> 5.5.4)
	- @babel/preset-env (7.24.8 -> 7.25.3)
	- django (5.0.7 -> 5.0.8)
	- pyyaml (6.0.1 -> 6.0.2)
	- gunicorn (22.0.0 -> 23.0.0)
	- paramiko (3.4.0 -> 3.4.1)
- Updated dependencies (release-helper)
	- clap (4.5.9 -> 4.5.16)
	- regex (1.10.5 -> 1.10.6)
- Updated dependencies (shippy)
	- sentry-sdk (2.9.0 -> 2.13.0)
	- setuptools (70.3.0 -> 72.2.0)
@ericswpark
Copy link
Collaborator Author

Not a complete fix for multiple layered reverse proxies, re-opening

@ericswpark ericswpark reopened this Aug 17, 2024
ericswpark added a commit that referenced this issue Aug 18, 2024
@ericswpark
release: 2.41.2
4beb3f9 
## Added

- Added main internal admin page (for linking)

## Changed

- The internal admin page for tracking build mirror status now shows more stats for each item
- Fixed the nginx proxy configuration for layered reverse proxies (#562)
- Fixed the release helper ignoring Markdown headings during release (#563)
- General code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericswpark ericswpark

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericswpark