Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix issue where IPv6 caused issue #136

Merged
merged 2 commits into from
Mar 17, 2020
Merged

chore: fix issue where IPv6 caused issue #136

merged 2 commits into from
Mar 17, 2020

Conversation

vinayakkulkarni
Copy link
Contributor

@fideloper
Copy link
Contributor

fideloper commented Mar 17, 2020 •
edited
Loading

Thanks!

What do you think about making that all one RUN statement since it's related to installing the packages:

RUN mkdir ~/.gnupg \
    && echo "disable-ipv6" >> ~/.gnupg/dirmngr.conf \
    && echo "deb http://ppa.launchpad.net/ondrej/php/ubuntu bionic main" ...

@vinayakkulkarni
chore: fix issue where IPv6 caused issue
ff224a4 
while connecting to keyserver
@vinayakkulkarni vinayakkulkarni force-pushed the fix/ipv6-keyserver-issue branch from 5e73630 to ff224a4 Compare March 17, 2020 08:21
@vinayakkulkarni
Copy link
Contributor Author

Thanks!

What do you think about making that all one RUN statement since it's related to installing the packages:

RUN mkdir ~/.gnupg \
    && echo "disable-ipv6" >> ~/.gnupg/dirmngr.conf \
    && echo "deb http://ppa.launchpad.net/ondrej/php/ubuntu bionic main" ...
  • Done

@fideloper fideloper merged commit 9fff98c into shipping-docker:master Mar 17, 2020
@fideloper
Copy link
Contributor

thanks again!

@vinayakkulkarni vinayakkulkarni deleted the fix/ipv6-keyserver-issue branch March 18, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinayakkulkarni @fideloper