Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tour.options.defaults to tour.options.stepOptions #240

Closed
BrianSipple opened this issue Sep 8, 2018 · 1 comment
Closed

Change tour.options.defaults to tour.options.stepOptions #240

BrianSipple opened this issue Sep 8, 2018 · 1 comment
Assignees
@BrianSipple
Labels
enhancement

Comments

@BrianSipple
Copy link
Contributor

It would also be useful to see if we can add a deprecation message for the original tour.options.defaults parameter -- rather than eliminating altogether.
@BrianSipple BrianSipple self-assigned this Sep 8, 2018
@RobbieTheWagner
Copy link
Member

Perhaps defaultStepOptions, globalStepOptions, etc? Not sure what is most clear here. Open to whatever. Is the idea just to have step in the param name, so people know the options are to be merged with the step options, not options for the tour itself?

BrianSipple added a commit that referenced this issue Sep 11, 2018
@BrianSipple
Rename Tour.options.defaults to Tour.options.defaultStepOptions.
3e54f39 
Closes [#240](#240).
@BrianSipple BrianSipple mentioned this issue Sep 11, 2018
Merged
BrianSipple added a commit that referenced this issue Sep 12, 2018
@BrianSipple
Rename Tour.options.defaults to Tour.options.defaultStepOptions.
e230ea9 
Closes [#240](#240).
BrianSipple added a commit that referenced this issue Sep 12, 2018
@BrianSipple
Rename Tour.options.defaults to Tour.options.defaultStepOptions.
ac87568 
Closes [#240](#240).
RobbieTheWagner pushed a commit that referenced this issue Sep 12, 2018
@BrianSipple @RobbieTheWagner
Rename Tour.options.defaults to Tour.options.defaultStepOptions. (#…
770168d 
…244)

Closes [#240](#240).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrianSipple BrianSipple

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobbieTheWagner @BrianSipple