-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use data attributes for element selection in demo/tests #273
Comments
This would be great! I'm used to using them in Ember via ember-test-selectors. Is there a package that is not Ember specific that will strip them out of production builds for us? |
@rwwagner90 I think this would just apply to the demo app and test dummy app. Aren't we already keeping all of that code out of the production build? |
@BrianSipple yeah, good point. That works then 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This will make our testing much less brittle — and set a good example for users of Shepherd.
(Cy, among many sources, knows what's up).
The text was updated successfully, but these errors were encountered: