Show event of tour does not pass the hash of step and previous

[hodossy]

I am using Shepherd 2.8.0. The problem is in trigger where the arguments is passed to drop, since arguments is not an Array, therefore always an empty list is returned and passed to the show handler as args.

An easy fix would be to convert to array before passing to drop:

trigger(event) {
    if (!isUndefined(this.bindings) && this.bindings[event]) {
      const args = drop(Array.prototype.slice.call(arguments));

      this.bindings[event].forEach((binding, index) => {
        const { ctx, handler, once } = binding;

        const context = ctx || this;

        handler.apply(context, args);

        if (once) {
          this.bindings[event].splice(index, 1);
        }
      });
}

[RobbieTheWagner]

Hello @hodossy, it appears the links you posted link to a bunch of old issues, not to lines in the code.

I recently switched from using drop from lodash, to making it an internal util. Perhaps the lodash one handled when things were not arrays? I think we should fix this by modifying the drop util to do what lodash did, assuming it worked for you before with lodash?

If that sounds reasonable, and you would be comfortable submitting a PR for the change, that would be awesome!

[RobbieTheWagner]

@chuckcarpenter @jaredgalanis if either of you have some time to look into this, let me know as well.

[hodossy]

Hello @rwwagner90, I have fixed the links, sorry for that! I wanted to submit a PR, but I had trouble setting up the dev env on Windows (build command fails due to rm is not know by windows, but I have the windows build tools installed). The corrections are working for me as shown in my prev post.

[RobbieTheWagner]

@hodossy can we please fix it with my suggestion above?

I recently switched from using drop from lodash, to making it an internal util. Perhaps the lodash one handled when things were not arrays? I think we should fix this by modifying the drop util to do what lodash did, assuming it worked for you before with lodash?

As for the rm issue. We could install rimraf or cross-env as a devDep, and use instead of rm.

[hodossy]

Lodash basicaly reimplemented slice, so if you want that, then another function needs to be ported.

[RobbieTheWagner]

@hodossy I am just asking if we could please make the changes to fix things inside the drop function. Perhaps passing just arguments to drop and doing Array.prototype.slice.call(arguments) inside drop etc. I am not 100% sure what would be best, but what I am going for here is to fix things inside drop, rather than trigger.

[RobbieTheWagner]

It appears the only thing currently using drop is trigger, so I am going to proceed with the solution you recommended. Thanks so much @hodossy!