Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup jest comments, update yarn.lock #1920

Merged
merged 2 commits into from
May 16, 2022
Merged

Cleanup jest comments, update yarn.lock #1920

merged 2 commits into from
May 16, 2022

Conversation

monshan
Copy link
Contributor

@monshan monshan commented May 16, 2022 •
edited
Loading

Background:
Bugfix due to branch #1919

  • Fix node version mis-alignment
  • Leftover docblocks due to coverage by Jest configuration

Changes:

  • Remove 3 remaining docblocks (hard delete)
  • Remove package-lock.json file (hard delete)
  • Re-write yarn.lock file (triggered by local machine run of yarn command to manage packages)

@monshan monshan added the bug label May 16, 2022
@monshan monshan requested a review from RobbieTheWagner May 16, 2022 19:14
@RobbieTheWagner RobbieTheWagner changed the title Bugfix from 1919 manage yarn and jest Cleanup jest comments, update yarn.lock May 16, 2022
@RobbieTheWagner RobbieTheWagner merged commit 945b184 into master May 16, 2022
@RobbieTheWagner RobbieTheWagner deleted the bugfix-from-1919-manage-yarn-and-jest branch May 16, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monshan @RobbieTheWagner