Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel link color for when the header has dark background #477

Merged

Conversation

genadis
Copy link
Contributor

@genadis genadis commented Aug 1, 2019

when dark color is used for header for example: shepherdHeaderBackground: 'rgb(20,20,20)' the cancel link color is broken:

  • when there is no title, the 'x' cancel link is white and not visible at all.
  • when there is title the 'x' cancel link is white and there is no transparency at all and no hover effect.

This fix, fixes it without breaking light header backgrounds.

@RobbieTheWagner RobbieTheWagner merged commit b7bf5ae into shipshapecode:master Aug 1, 2019
@RobbieTheWagner RobbieTheWagner changed the title fix cancel link color for when the header has dark background Fix cancel link color for when the header has dark background Aug 1, 2019
@genadis genadis deleted the cancel-link-color-fix branch August 1, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants