fix(style): remove use of discouraged functions

shipstation · Mar 20, 2024 · 5b475a7 · 5b475a7
1 parent dec9e1e
commit 5b475a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Api/Model/Action/Export.php b/Api/Model/Action/Export.php
@@ -293,7 +293,7 @@ private function writeOrderXml(Order $order): self
         $this->_xmlData .= "\t<Items>\n";
         $this->_orderItem($order); //call to the order items function
         //Get the order discounts
-        if ($this->_importDiscount && !is_null($order->getDiscountAmount()) && $order->getDiscountAmount() != '0.0000') {
+        if ($this->_importDiscount && $order->getDiscountAmount() !== NULL && $order->getDiscountAmount() != '0.0000') {
             $this->_getOrderDiscounts($order);
         }
 
@@ -349,7 +349,7 @@ private function _getGiftMessageInfo($messageContainer): self
             $this->addXmlElement("GiftMessage", "<![CDATA[From: {$gift->getSender()}\nTo: {$gift->getRecipient()}\nMessage: {$gift->getMessage()}]]>");
         }
 
-        $this->addXmlElement("Gift", !is_null($giftId) ? 'true' : 'false');
+        $this->addXmlElement("Gift", $giftId !== NULL ? 'true' : 'false');
 
         return $this;
     }
@@ -364,7 +364,7 @@ private function _getBillingInfo(Order $order): self
     {
         $billing = $order->getBillingAddress();
 
-        if (is_null($billing)) {
+        if ($billing === NULL) {
             return $this;
         }
 

diff --git a/Api/Model/Carrier/Shipping.php b/Api/Model/Carrier/Shipping.php
@@ -380,7 +380,7 @@ protected function _getCartDetails($shippingRequest, $request)
                     'name' => $item->getname(),
                     'weight' => array('units' => $this->_scopeConfig->getValue('general/locale/weight_unit', $scopeTypeStore),
                                     'value' => $item->getWeight()),
-                    'price_per_item' => array( 'currency' =>$this->storeManager->getStore()->getCurrentCurrency()->getCode(), 'amount' => strval($item->getPrice())),
+                    'price_per_item' => array( 'currency' =>$this->storeManager->getStore()->getCurrentCurrency()->getCode(), 'amount' => (string)$item->getPrice()),
                     'quantity' => $item->getQty(),
                 );
                 array_push($shippingRequest['items'], $shipstation_item);