Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miso Soup Spelling Error #3370

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Miso Soup Spelling Error #3370

merged 3 commits into from
Sep 23, 2024

Conversation

trazodont
Copy link
Contributor

About The Pull Request

Corrects spelling for "milo soup" to "miso soup"
image

Why It's Good For The Game

idk why it was named milo anyways, there's literally a comment that says "wtf is milo".

Changelog

🆑
fix: miso soup spelling error
/:cl:

@trazodont trazodont requested a review from a team as a code owner September 15, 2024 23:59
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Sep 15, 2024
@thgvr
Copy link
Member

thgvr commented Sep 16, 2024

soulless...

@FalloutFalcon
Copy link
Member

you have some checks failing! I kinda like milo soup tbh its silly and i like the idea a character got mixed up at some point.

@FalloutFalcon
Copy link
Member

i vote we keep milo but i wont close it till i get others opinions

@rye-rice rye-rice added this pull request to the merge queue Sep 23, 2024
Merged via the queue into shiptest-ss13:master with commit b065692 Sep 23, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Sep 28, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
Corrects spelling for "milo soup" to "miso soup"

![image](https://github.com/user-attachments/assets/8636445c-126c-4248-99ed-ad1ea1e4a9a2)

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->
idk why it was named milo anyways, there's literally a comment that says
"wtf is milo".
## Changelog

:cl:
fix: miso soup spelling error
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@trazodont trazodont deleted the miso branch October 6, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants