Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[x] Ship Console Refactor | [ ] Ship Modules / Machinery #434

Closed
wants to merge 43 commits into from
Closed

[x] Ship Console Refactor | [ ] Ship Modules / Machinery #434

wants to merge 43 commits into from

Conversation

ZephyrTFA
Copy link
Member

About The Pull Request

Refactors the helms console to be part of a unique ship subtype that connects to and populates a current_ship var so that the consoles dont have to copy/paste code constantly to get their current ship!

As of creating this draft some module logic has been created but its far from finished.
Modules will be stuff along the lines of: shields, scanners, radars, WEAPONS, etc

Why It's Good For The Game

[Mark write something here]

Changelog

🆑
refactor: dedicated ship console subtypes
code: helms console now uses the subtypes
add: module and machinery framework for ships
add: bluespace jump control console
/:cl:

@github-actions github-actions bot added DME Edit Map Change Tile placing is hard. Thank you for your service. TGUI labels Nov 15, 2021
@ilikesaying
Copy link

As of creating this draft some module logic has been created but its far from finished. Modules will be stuff along the lines of: shields, scanners, radars, WEAPONS, etc

ship combat in the future???

@github-actions github-actions bot added the Sprites A bikeshed full of soulless bikes. label Nov 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 4, 2021
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale All falls to entropy eventually. label Dec 29, 2021
@ZephyrTFA
Copy link
Member Author

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Begone thot

@ZephyrTFA ZephyrTFA closed this Dec 29, 2021
@ZephyrTFA ZephyrTFA deleted the outpostorio branch June 11, 2022 00:19
@ZephyrTFA ZephyrTFA removed the Stale All falls to entropy eventually. label Sep 22, 2022
SuhEugene pushed a commit to SuhEugene/Shiptest that referenced this pull request Apr 26, 2024
…-patch-1

Исправление ошибок в документации
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DME Edit Map Change Tile placing is hard. Thank you for your service. Merge Conflict Use Git Hooks, you're welcome. Sprites A bikeshed full of soulless bikes. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants