Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Kaniko version and arguments in sync #438

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

SaschaSchwarze0
Copy link
Member

In my recent Kaniko-related PR where I upleveled it to v1.0.0, I forgot the s2i build strategy and also missed to add the --oci-layout-path argument to the runtime image support. Correcting this with this PR.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign saschaschwarze0 after the PR has been reviewed.
You can assign the PR to them by writing /assign @saschaschwarze0 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@qu1queee qu1queee merged commit d93cf57 into shipwright-io:master Oct 9, 2020
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-kaniko-sync branch October 9, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants