Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Illegal Byte Sequence #52

Merged

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Oct 8, 2021

Changes

Small pull-request to avoid possible errors reading /dev/urandom with tr. As in:

$ tr -dc a-z < /dev/urandom
tr: Illegal byte sequence

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@otaviof otaviof assigned otaviof and unassigned otaviof Oct 8, 2021
@otaviof otaviof added the kind/bug Categorizes issue or PR as related to a bug. label Oct 8, 2021
@otaviof
Copy link
Member Author

otaviof commented Oct 8, 2021

/assign @akram
/assign @coreydaley

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2021

@otaviof: GitHub didn't allow me to assign the following users: akram.

Note that only shipwright-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @akram
/assign @coreydaley

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2021
@openshift-merge-robot openshift-merge-robot merged commit 44c0a85 into shipwright-io:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants