Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Dockerfile is not set to empty string #58

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

When creating a build like this:

$ shp build create sample-go --source-url https://github.com/shipwright-io/sample-go --source-context-dir docker-build --strategy-name kaniko --output-image ... --output-credentials-secret ...

then, spec.dockerfile was set to "" which does not work. It is defined as a *string and therefore must be set to nil instead.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

When providing no value for the --dockerfile argument during build creation, then it is not anymore set to an empty string

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Oct 17, 2021
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.6.0 milestone Oct 17, 2021
Copy link
Member

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

thanks @SaschaSchwarze0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2021
@openshift-merge-robot openshift-merge-robot merged commit be770b4 into main Oct 18, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-prevent-empty-dockerfile branch October 18, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants